Skip to content

Conversation

@DN6
Copy link
Collaborator

@DN6 DN6 commented Jul 23, 2024

What does this PR do?

We have a couple of flaky tests related to the number of GET requests being performed when fetching a model. The issue only seems to happen in the when the test is triggered via CI and it is not reproducible when SSHing into the runner and running the same tests or the entire test suite.

Since we're migrating to new runner groups soon, let's skip these tests for now and re-enable with the new machines to see if it fixes it.

Fixes # (issue)

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@DN6 DN6 requested a review from sayakpaul July 23, 2024 15:51
@sayakpaul
Copy link
Member

But even when sshd into the runner I am unable to reproduce the error though:

and it reproducible when SSHing into the runner and running the same tests

@DN6
Copy link
Collaborator Author

DN6 commented Jul 24, 2024

@sayakpaul sorry meant to say "not reproducible". Updated the description.

@sayakpaul sayakpaul merged commit 93983b6 into main Jul 24, 2024
@sayakpaul sayakpaul deleted the pr-test-skip branch July 24, 2024 03:55
@sayakpaul
Copy link
Member

Might be also nice to check what we discussed in https://huggingface.slack.com/archives/C02V5EA0A95/p1721630115211789

sayakpaul pushed a commit that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants