Store a list of arrays at each location so duplicates aren't lost

[geekykayaker]

Summary

Some Nanoleaf LEDs are in a strip
The Nanoleaf code calculates a position for each LED and stores each LED ID in a map, keying of X,Y.
With the layouts provided, LEDs have "overlapping" positions in X,Y in the corners.
This means that multiple LEDs land in the same map entry, overwriting existing IDs in the map.

At the end of the Nanoleaf init function is code to check the size of the map matches the number of LEDs.
In my setup, this was failing because of the 'overwritten' IDs aren't counted.

To fix this I've changed the value of the Map to be a vector of IDs, which allows for duplicates to be tracked correctly.
I've also improved the logging slightly to show that duplicates have been found.

This change is expected to have zero impact on any previously working configuration, as all the vectors will have size 1

What kind of change does this PR introduce? (check at least one)

• Bugfix
• Feature
• Code style update
• Refactor
• Docs
• Build-related changes
• Other, please describe:

If changing the UI of web configuration, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

• Yes
• No

If yes, please describe the impact and migration path for existing setups:

The PR fulfills these requirements:

• When resolving a specific issue, it's referenced in the PR's body (e.g. Fixes: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

• A convincing reason for adding this feature
• Related documents have been updated (docs/docs/en)
• Related tests have been updated

PLEASE DON'T FORGET TO ADD YOUR CHANGES TO CHANGELOG.MD

• Yes, CHANGELOG.md is also updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

[Lord-Grey]

@geekykayaker Thank you so much for your contribution and improving the Nanoleaf codebase.
Have you had the chance to check, if the "Generate Layout" code in the UI works correctly for the overlapping panel scenario?

I assume so, but would like to be on the save side :)

hyperion.ng/assets/webconfig/js/content_leds.js

Line 2695 in 33b5c6f

function nanoleafGeneratelayout(panelLayout, panelOrderTopDown, panelOrderLeftRight) {

[geekykayaker]

Actually, there are further issues with this set up…
The kit I’m using is the Nanoleaf 4D that came with a camera.
It looks like the Nanoleaf controller itself remaps the LEDs, because when Hyperion lights up the LEDs sequentially the Nanoleaf lights don’t light up sequentially, but every LED did appear to light at some point in the sequence.
For Hyperion to work, I’d have to manually enter the coordinates of each remapped LED, and which would have been very manual and hard to calibrate.
Instead, I have cut up the LED strip to try and wire to my own controller, so unfortunately I can’t do further testing.
I still think that doing “something” is better that failing with an “error”, but appreciate this change doesn’t fix everything.

[Lord-Grey]

For Hyperion to work, I’d have to manually enter the coordinates of each remapped LED, and which would have been very manual and hard to calibrate.

This would have to be addressed by the layout generation...
...but anyway, thanks for the fix that the device will not fail.