-
Notifications
You must be signed in to change notification settings - Fork 140
feat(pool): import client::pool from hyper #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Oh right... Hm, I think this is something we'll need to experiment with, and won't have the full solution when merging this PR, and that's OK. We might just return a It might just be easier to start with returning a |
I've replaced the |
src/client/pool.rs
Outdated
} | ||
} | ||
|
||
#[cfg(test)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#[cfg(test)] | |
#[cfg(all(test, not(miri)))] |
Looks like Miri is grumpy with some of the tests in here (sigh). This should make it stop :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. b162476
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I'm giving hyperium/hyper#2860 a go, but I'm not sure I'm going in the right direction.
Appreciate if you could take a look when you have time @seanmonstar
Some questions:
Some part of
pool
useshyper::Errors
I'd imagine that it's probably best to expose these functions from
hyper::Error
, but I'm not sure that this would follow the plan forhyper-util
?