Update event queue to support readahead to FireFly core #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Broadhurst <[email protected]>
Signed-off-by: Peter Broadhurst <[email protected]>
…queue full Signed-off-by: Peter Broadhurst <[email protected]>
gabriel-indik
approved these changes
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Investigating the logs from a recent long run, I found a bottleneck in sequential processing of events from DX. PR hyperledger/firefly#653 addresses the big inefficiency that showed up in the long run test, and made the issue very evident in the logs.
However, for higher throughput it's obvious to me looking at this code that we need parallelism and batching in how we process blob confirmation messages in particular.
This means we need to process multiple DX events in parallel, and currently the FFDX API contract doesn't support that. You have to ack one-by-one.
This PR updates the HTTPS data exchange to add a simple readahead support, updating the ack contract so you have to specify which event you're acking.