Feature/config for json serialization #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @vadymmarkov to be a potential reviewer |
| import Foundation | ||
|
|
||
| /// A configuration struct | ||
| public struct CacheJSONOptions { |
Contributor
Author
There was a problem hiding this comment.
Yeah we could totally do that! 😁
Contributor
Author
There was a problem hiding this comment.
@onmyway133 I added the namespace to scope it as it is global.
Contributor
There was a problem hiding this comment.
@zenangst it is OK
Although every "global" is actually under the framework namespace 😬
Contributor
Author
There was a problem hiding this comment.
That is actually true!
Contributor
Author
|
@vadymmarkov @onmyway133 is it okay now? |
Contributor
|
@zenangst Please roll back to |
Contributor
Author
|
@vadymmarkov oh you! :) |
This reverts commit cb9b524.
Contributor
Author
|
Done |
Contributor
|
I got it wrong, thought it like a wrapper, but actually it's a config. |
Contributor
Author
|
No worries 😁 |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds configuration options for NSJSONSerialization.
It can be configured like this;