refactor: remove ERC1538 references and update related configurations #52
Conversation
Le-Caignec
temporarily deployed
to
arbitrumSepolia
GitHub Actions
Inactive
Le-Caignec
temporarily deployed
to
arbitrumSepolia
GitHub Actions
Inactive
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the codebase by completely removing ERC1538 proxy contract references and updating configurations to use Core contracts directly. This appears to be a migration from an ERC1538 proxy pattern to a direct Core contract approach.
- Removes all ERC1538-related code including event handlers, schema definitions, and data sources
- Updates network configurations to remove ERC1538 addresses and update Core/registry addresses for arbitrum-sepolia
- Removes dependency on @iexec/solidity package which was used for ERC1538 interfaces
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/e2e/integration.test.ts | Updates proxy address reference from ERC1538 to Core contract |
| subgraph.yaml | Removes ERC1538 data source configuration completely |
| src/ERC1538/ERC1538.ts | Deletes entire ERC1538 event handler implementation |
| schema.graphql | Removes all ERC1538-related GraphQL schema definitions |
| package.json | Removes @iexec/solidity dependency |
| networks.json | Removes ERC1538 configurations and updates arbitrum-sepolia addresses |
| README.md | Updates documentation to remove ERC1538 configuration example |
| "Core": { | ||
| "address": "0x14B465079537655E1662F012e99EBa3863c8B9E0", | ||
| "startBlock": 145249746 | ||
| "address": "0xB2157BF2fAb286b2A4170E3491Ac39770111Da3E", |
There was a problem hiding this comment.
The Core contract address for arbitrum-sepolia has changed from the same address used for ERC1538 (0x14B465079537655E1662F012e99EBa3863c8B9E0) to a new address (0xB2157BF2fAb286b2A4170E3491Ac39770111Da3E). This significant change should be documented or verified to ensure it's intentional and correct.
| "address": "0x14B465079537655E1662F012e99EBa3863c8B9E0", | ||
| "startBlock": 145249746 | ||
| "address": "0xB2157BF2fAb286b2A4170E3491Ac39770111Da3E", | ||
| "startBlock": 178282956 |
There was a problem hiding this comment.
The startBlock for arbitrum-sepolia Core contract has changed significantly from 145249746 to 178282956. This large block number jump suggests a major deployment change that should be verified for correctness and documented.
| "address": "0x14B465079537655E1662F012e99EBa3863c8B9E0", | ||
| "startBlock": 145249746 | ||
| }, | ||
| "Core": { |
There was a problem hiding this comment.
TODO: rename it to Diamond in the future.
3 participants
No description provided.