-
Notifications
You must be signed in to change notification settings - Fork 14
fix: set named account and change admin to owner naming #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ency across scripts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR standardizes account management by implementing named accounts through hardhat-deploy and changes terminology from "admin" to "owner" for consistency. The changes centralize account retrieval using getNamedAccounts() instead of directly accessing signers by index.
- Replaced direct signer access with named account pattern using
getNamedAccounts() - Updated configuration to define
deployerandownernamed accounts with fallback logic - Renamed "admin" references to "owner" for consistent terminology
Reviewed Changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| hardhat.config.ts | Added namedAccounts configuration with deployer/owner mappings and helper function |
| scripts/upgrades/deploy-and-update-some-facet.ts | Updated to use named accounts and renamed admin references to owner |
| scripts/sponsoring/1_add-modules-to-proxy.ts | Changed from direct signer access to named owner account |
| scripts/sponsoring/0_deploy-modules.ts | Updated to use named deployer account |
| scripts/set-callback-gas.ts | Replaced TODO comment with named owner account implementation |
| scripts/deploy-timelock.ts | Changed from owner signer to named deployer account |
| scripts/boost/1_add-modules-to-proxy.ts | Updated to use named owner account |
| scripts/boost/0_deploy-modules.ts | Changed from owner signer to named deployer account |
| deploy/0_deploy.ts | Updated to use named deployer account |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #276 +/- ##
==========================================
+ Coverage 83.66% 84.82% +1.16%
==========================================
Files 38 37 -1
Lines 1218 1239 +21
Branches 227 235 +8
==========================================
+ Hits 1019 1051 +32
+ Misses 199 188 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… config files for consistency
… deployment scripts
No description provided.