Skip to content

Conversation

@gfournieriExec
Copy link
Contributor

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR standardizes account management by implementing named accounts through hardhat-deploy and changes terminology from "admin" to "owner" for consistency. The changes centralize account retrieval using getNamedAccounts() instead of directly accessing signers by index.

  • Replaced direct signer access with named account pattern using getNamedAccounts()
  • Updated configuration to define deployer and owner named accounts with fallback logic
  • Renamed "admin" references to "owner" for consistent terminology

Reviewed Changes

Copilot reviewed 9 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
hardhat.config.ts Added namedAccounts configuration with deployer/owner mappings and helper function
scripts/upgrades/deploy-and-update-some-facet.ts Updated to use named accounts and renamed admin references to owner
scripts/sponsoring/1_add-modules-to-proxy.ts Changed from direct signer access to named owner account
scripts/sponsoring/0_deploy-modules.ts Updated to use named deployer account
scripts/set-callback-gas.ts Replaced TODO comment with named owner account implementation
scripts/deploy-timelock.ts Changed from owner signer to named deployer account
scripts/boost/1_add-modules-to-proxy.ts Updated to use named owner account
scripts/boost/0_deploy-modules.ts Changed from owner signer to named deployer account
deploy/0_deploy.ts Updated to use named deployer account

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.82%. Comparing base (f7c634b) to head (ad62269).
⚠️ Report is 21 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #276      +/-   ##
==========================================
+ Coverage   83.66%   84.82%   +1.16%     
==========================================
  Files          38       37       -1     
  Lines        1218     1239      +21     
  Branches      227      235       +8     
==========================================
+ Hits         1019     1051      +32     
+ Misses        199      188      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gfournieriExec gfournieriExec merged commit 5857e81 into main Oct 10, 2025
4 checks passed
@gfournieriExec gfournieriExec deleted the fix/set-named-account branch October 10, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants