Fix enclave challenge generation failure. #663
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbern0rd
reviewed
Feb 12, 2024
| log.error("An error occurred while getting teeChallengePublicKey " | ||
| + "[chainTaskId:{}, smsUrl:{}]", chainTaskId, smsUrl); | ||
| return Optional.of(teeChallengePublicKey); | ||
| } catch (FeignException e) { |
There was a problem hiding this comment.
With a reverse proxy, other runtime exceptions could happen in production.
Do we want to have the biggest net and catch all exceptions here ?
There was a problem hiding this comment.
Thanks for the idea. Here is a commit addressing the issue: a8997d4
Catching unchecked exceptions should be enough there, as Feign methods contract do not allow them to throw checked exceptions.
|
jbern0rd
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.