Skip to content

Allow up to 32 task updates at a given time #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 28, 2024
Merged

Allow up to 32 task updates at a given time #703

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
46a4076
Remove upper limit on task update thread pool size
jbern0rd May 23, 2024
d9ef2f1
Rework comments to avoid alerts on commented code
jbern0rd May 24, 2024
c80ce7f
Fix stubs on some unit tests
jbern0rd May 24, 2024
66fa28f
Fix stubs on some unit tests
jbern0rd May 24, 2024
2ececa8
Update unit tests
jbern0rd May 24, 2024
7329d99
Update unit tests
jbern0rd May 24, 2024
6e8f099
Update unit tests
jbern0rd May 24, 2024
25fdc37
Replace 3 unit tests with 1 parameterized test
jbern0rd May 24, 2024
da606d7
Set task update thread pool size to 32
jbern0rd May 27, 2024
4de3d7e
Update unit tests
jbern0rd May 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ All notable changes to this project will be documented in this file.
- Move `notification` package from `iexec-commons-poco` to `iexec-core-library`. (#697 #698)
- Move `PublicConfiguration` class from `iexec-common` to `iexec-core-library`. (#699)
- Create `ConfigServerClient` instance and use it. (#700)
- Allow up to 32 task updates at a given time. (#703)

### Bug Fixes

Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/iexec/core/task/update/TaskUpdateRequestManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public class TaskUpdateRequestManager {
/**
* Max number of threads to update task for each core.
*/
private static final int TASK_UPDATE_THREADS_POOL_SIZE = Runtime.getRuntime().availableProcessors() * 2;
private static final int TASK_UPDATE_THREADS_POOL_SIZE = 32;

// Working with semaphore to guarantee at most 1 item in queue and 1 running thread
private final ExpiringMap<String, Semaphore> taskExecutionLockRunner = ExpiringMap.builder()
Expand Down
Loading