Skip to content

Add broken tests for internal modules (see #807) #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Whoaa512
Copy link

@Whoaa512 Whoaa512 commented May 1, 2017

Including one broken test related to the #807

Including one broken test related to the import-js#807
@Whoaa512 Whoaa512 force-pushed the internal-modules-broken-test branch from d0efd9a to 9a8f7de Compare May 1, 2017 23:33
@Whoaa512 Whoaa512 changed the title Add tests for internal modules Add broken tests for internal modules (see #807) May 15, 2017
@Whoaa512
Copy link
Author

Closing due to inactivity

@Whoaa512 Whoaa512 closed this Mar 28, 2020
@ljharb
Copy link
Member

ljharb commented Mar 28, 2020

#807's still open, so this PR remains helpful :-)

@ljharb ljharb reopened this Mar 28, 2020
@ljharb ljharb force-pushed the internal-modules-broken-test branch from 9a8f7de to 27190e9 Compare January 31, 2021 22:27
@ljharb ljharb force-pushed the internal-modules-broken-test branch from 27190e9 to b70a8f0 Compare January 31, 2021 22:29
@Whoaa512
Copy link
Author

any movement here? Looking to close out stale PRs

@Whoaa512 Whoaa512 closed this Nov 17, 2021
@ljharb
Copy link
Member

ljharb commented Nov 17, 2021

It's very helpful to keep it open; that there's no movement yet doesn't lessen the chance there will be eventually. Hopefully you don't mind keeping it open.

@ljharb ljharb reopened this Nov 17, 2021
@ljharb
Copy link
Member

ljharb commented Nov 17, 2021

I'll rebase this now and see if it's still failing.

@ljharb ljharb force-pushed the internal-modules-broken-test branch from b70a8f0 to d863014 Compare November 17, 2021 20:41
@Whoaa512
Copy link
Author

If it's broken the failed test should be merged and skipped until the feature lands to fix it. I don't understand the need to keep PRs open if it's only purpose is to sit here unanswered

@ljharb
Copy link
Member

ljharb commented Nov 18, 2021

What's the need to close them? A PR, once opened, should remain open for as long as needed for it to be landed. Landing a broken test that's skipped is a recipe to never clean it up; the open PR is an invitation for anyone to come along and fix it.

@Whoaa512 Whoaa512 closed this Jul 9, 2025
@ljharb ljharb reopened this Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants