-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add broken tests for internal modules (see #807) #817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Including one broken test related to the import-js#807
d0efd9a
to
9a8f7de
Compare
Closing due to inactivity |
#807's still open, so this PR remains helpful :-) |
9a8f7de
to
27190e9
Compare
27190e9
to
b70a8f0
Compare
any movement here? Looking to close out stale PRs |
It's very helpful to keep it open; that there's no movement yet doesn't lessen the chance there will be eventually. Hopefully you don't mind keeping it open. |
I'll rebase this now and see if it's still failing. |
b70a8f0
to
d863014
Compare
If it's broken the failed test should be merged and skipped until the feature lands to fix it. I don't understand the need to keep PRs open if it's only purpose is to sit here unanswered |
What's the need to close them? A PR, once opened, should remain open for as long as needed for it to be landed. Landing a broken test that's skipped is a recipe to never clean it up; the open PR is an invitation for anyone to come along and fix it. |
Including one broken test related to the #807