Skip to content

Conversation

@tomklapka
Copy link
Contributor

Created a release profile which is automatically activated when running the maven-release-plugin including the InfluxDB started before tests execution (run via the docker-compose-maven-plugin) and stopped after.

@ivankudibal ivankudibal merged commit d54d4fc into influxdata:master Feb 27, 2018
@majst01
Copy link
Collaborator

majst01 commented Feb 27, 2018

Guys please do not merge stuff which changes a whole file. Always check before you commit and merge at the end that the formatting is untouched. I dont like this this way because its impossible to see what actually changed.

@ivankudibal please revert and fix formatting first.

@codecov-io
Copy link

Codecov Report

Merging #421 into master will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #421      +/-   ##
============================================
+ Coverage     84.86%   85.03%   +0.16%     
  Complexity      270      270              
============================================
  Files            19       19              
  Lines          1183     1183              
  Branches        119      119              
============================================
+ Hits           1004     1006       +2     
+ Misses          118      116       -2     
  Partials         61       61
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/influxdb/impl/InfluxDBImpl.java 85.66% <0%> (+0.65%) 61% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48c075d...9b200f0. Read the comment docs.

@majst01
Copy link
Collaborator

majst01 commented Mar 1, 2018

@ivankudibal @tomklapka still not reverted, please i really do not want to have such commits which change ~250 lines with no obvious view what changed.

@tomklapka
Copy link
Contributor Author

tomklapka commented Mar 2, 2018

Fixed with commit 0e78b6c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants