Fix wrong parameter passed to getModuleFileName #655
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @vladislav-ryabov |
vladislav-ryabov
force-pushed
the
getModuleFileName_parameter_fix
branch
from
c64ae9a to
a30d2ea
Compare
The size was passed in bytes, not in number of TCHARs. Signed-off-by: Vladislav Ryabov <[email protected]>
vladislav-ryabov
force-pushed
the
getModuleFileName_parameter_fix
branch
from
a30d2ea to
fb2dced
Compare
|
@JablonskiMateusz done. |
|
Change merged 6d41a6b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compute-runtime/shared/source/os_interface/windows/driver_info_windows.cpp
Line 26 in 662146e
MAX_PATH should be passed instead of sizeof(pathW) since it calls GetModuleFileNameW and
https://learn.microsoft.com/en-us/windows/win32/api/libloaderapi/nf-libloaderapi-getmodulefilenamew
Signed-off-by: Vladislav Ryabov [email protected]