Skip to content

[SYCL][E2E] Add more xfails to recently re-enabled test #15878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

ayylol
Copy link
Contributor

@ayylol ayylol commented Oct 25, 2024

This test was failing on post commit in these cases after being re-enabled.
https://github.com/intel/llvm/actions/runs/11523103039

@ayylol ayylol requested a review from sarnex October 25, 2024 19:09
@ayylol ayylol requested a review from a team as a code owner October 25, 2024 19:09
@ayylol ayylol requested a review from uditagarwal97 October 25, 2024 19:09
Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for fast fix

@uditagarwal97
Copy link
Contributor

Can you add the link of the GH action that's failing?

@ayylol
Copy link
Contributor Author

ayylol commented Oct 25, 2024

we should probably let the post commit ci finish before merging to see if there are any other extra failures

@@ -1,4 +1,4 @@
// XFAIL: any-device-is-opencl, any-device-is-cuda, (windows && any-device-is-level_zero)
// XFAIL: any-device-is-opencl, any-device-is-cuda, (windows && any-device-is-level_zero), gpu-intel-dg2, hip_amd
// XFAIL-TRACKER: https://github.com/intel/llvm/issues/15819
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the corresponding GH issue: #15819 with the new failures on DG2 and HIP. It would be helpful to add links to the failing GHA job in the issue as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, done

Copy link
Contributor

@againull againull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I am not mistaken, Udit's concerns were addressed.

@againull againull merged commit 91ad0ed into intel:sycl Oct 25, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants