-
Notifications
You must be signed in to change notification settings - Fork 793
[SYCL] Diagnose local accessor use in single_task or parallel_for(range) #8581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mmoadeli
commented
Mar 8, 2023
- According to local accessors of the SYCL specification, a local accessor must not be used in a SYCL kernel function that is invoked via single_task or via the simple form of parallel_for that takes a range parameter.
- Add test.
Update failing tests due to adding diagnostic for const qualified DataT only allowed for non readonly accessor.
- Use -Xclang -verify for testing
Having it requires handling over 20 expected-erros.
…o inheritance from base class hitting assert.
…hat is invoked via single_task or via the simple form of parallel_for that takes a range parameter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/verify with intel/llvm-test-suite#1646 |
@bader there are a number of places in corresponding PR at llvm-test-suite which needs to be updated. I'll have them sorted out by tomorrow. That will make both ready to merge. |
👍 |
/verify with intel/llvm-test-suite#1646 |
/verify with intel/llvm-test-suite#1646 |
Windows L0 Failed Tests (1): |
@mmoadeli, I had to revert this patch because it introduced a lot of failures to both pre- and post-commit validation. Please, fix all these issues before re-applying the patch again. |