Skip to content

fix(app, expo): update iOS AppDelegate for SDK 53 support #8466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025

Conversation

LeonDvlpmnt
Copy link
Contributor

Description

In #8324 support was added for Swift templates. However this was done based on the AppDelegate.swift of react-native and not on the AppDelegate.swift of expo. Expo's version is quite a bit different and this caused the config plugin to fail. For config plugins it's necessary to use the template of Expo to make prebuild work correctly.

Expo SDK 52 never shipped with the swift template so this change will not break anything.

Related issues

Release Summary

Update config plugin to support Expo SDK 53

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
    • Other (macOS, web)
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

It's a bit difficult to test but this is what I did to validate that it works:

  • Set up a new expo SDK 53 beta project
  • Build the plugin
  • Copied the build folder to my own project (fb-plugin)
  • Added local plugin to app.json:
"plugins": {
  "./fb-plugin"
}
  • run npx expo prebuild --clean
  • ios/myapp/AppDelegate.Swift now has the correct imports

Think react-native-firebase is great? Please consider supporting the project with any of the below:

🔥

Copy link

vercel bot commented Apr 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2025 11:35pm

@CLAassistant
Copy link

CLAassistant commented Apr 11, 2025

CLA assistant check
All committers have signed the CLA.

@LeonDvlpmnt LeonDvlpmnt changed the title fix(app, expo): update iOS AppDelegate for SDK 53 support fix(app, expo): update config plugin to support Expo SDK 53 Apr 11, 2025
@LeonDvlpmnt LeonDvlpmnt changed the title fix(app, expo): update config plugin to support Expo SDK 53 fix(app, expo): update iOS AppDelegate for SDK 53 support Apr 11, 2025
Copy link
Collaborator

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems imminently reasonable - many thanks! - do you use AppCheck at all? I imagine the AppDelegate plugin logic there will need some work too, it also has to do an import and a line addition in the application method in order to slice in our custom provider so we can support dynamic config at the javascript level...

@mikehardy mikehardy merged commit a3d82c7 into invertase:main Apr 14, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants