fix(app, expo): update iOS AppDelegate for SDK 53 support #8466
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #8324 support was added for Swift templates. However this was done based on the AppDelegate.swift of react-native and not on the AppDelegate.swift of expo. Expo's version is quite a bit different and this caused the config plugin to fail. For config plugins it's necessary to use the template of Expo to make prebuild work correctly.
Expo SDK 52 never shipped with the swift template so this change will not break anything.
Related issues
Release Summary
Update config plugin to support Expo SDK 53
Checklist
Android
iOS
Other
(macOS, web)e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
It's a bit difficult to test but this is what I did to validate that it works:
fb-plugin
)npx expo prebuild --clean
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter🔥