-
Notifications
You must be signed in to change notification settings - Fork 13.5k
bug: Swipeable Segments - vertical scrolling should be disabled #30001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I experience the same behavior using the latest ionic version. As a workaround until this is fixed I put an "ion-content" inside of the "ion-segment-content"
|
@Hesesses Thanks for the issue! Definitely a small oversight on my part during the implementation. Will get this fixed! |
@Hesesses Do you have a repro or possibly just a snippet of your code/CSS? I haven't been able to reproduce the behavior in the browser or a capacitor app. |
I havent played this anymore after the issue created but i think the problem is when the content height is more than 100vh. view:
my pd-tabs component:
league-information-tab
|
@Hesesses Sorry for the delay again, was out for the Holiday last week. I was able to reproduce the behavior when setting a height > 100vh on the Any reason this approach wouldn't work for you? |
I tried to add height for |
@Hesesses I'm not seeing the multi-scroll behavior when setting height on the |
Is it possible for you to give example how its working for you? I have tried to set height on |
@Hesesses A simple use case where you can see it is the Ionic docs Stackblitz example setting the height to |
Hi, Edit. I now started to play around with height: 200vh, and if you change this to something smaller than the actual content height, then you can scroll vertically and horizontally at the same time. In my opinion this should work without setting specific height |
@tanner-reits is there something more you would like to know about this? |
I also experienced this and also have temporarily worked around it with the |
…ly (#30276) Issue number: resolves #30001 --------- <!-- Please do not submit updates to dependencies unless it fixes an issue. --> <!-- Please try to limit your pull request to one type (bugfix, feature, etc). Submit multiple pull requests if needed. --> ## What is the current behavior? <!-- Please describe the current behavior that you are modifying. --> When segment view has content that is long enough to render outside of the viewport, then a user can scroll vertically and horizontally when the user scrolled down to see the content at the bottom. This causes disorientation as scrolling should only be in one direction. This only happens on a mobile device, specifically Android. It can be reproduce with a browser simulator. ## What is the new behavior? <!-- Please describe the behavior or changes that are being added by this PR. --> - Updated styling to take into account that content might be outside of the viewport. ## Does this introduce a breaking change? - [ ] Yes - [x] No <!-- If this introduces a breaking change: 1. Describe the impact and migration path for existing applications below. 2. Update the BREAKING.md file with the breaking change. 3. Add "BREAKING CHANGE: [...]" to the commit description when merging. See https://github.com/ionic-team/ionic-framework/blob/main/docs/CONTRIBUTING.md#footer for more information. --> ## Other information <!-- Any other information that is important to this PR such as screenshots of how the component looks before and after the change. --> Dev build: `8.5.2-dev.11743531350.19e040aa`
Thanks for the issue! This has been resolved via PR #30276 and will be available in an upcoming release of Ionic. |
This issue was fixed in v8.5.3! Please update to the latest version to receive the fix. |
Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out. |
Prerequisites
Ionic Framework Version
v8.x
Current Behavior
When swiping between the views, it should only scroll horizontally, not vertically
See video:
RPReplay_Final1730847719.MP4
Expected Behavior
Only scrolling horizontally
See video:
RPReplay_Final1730847678.MP4
Steps to Reproduce
See both videos above
Code Reproduction URL
no url
Ionic Info
Ionic:
Ionic CLI : 7.2.0 (/Users/.../.nvm/versions/node/v18.20.4/lib/node_modules/@ionic/cli)
Ionic Framework : @ionic/angular 8.4.0
@angular-devkit/build-angular : 17.3.11
@angular-devkit/schematics : 17.3.11
@angular/cli : 17.3.11
@ionic/angular-toolkit : 11.0.1
Capacitor:
Capacitor CLI : 6.1.2
@capacitor/android : 6.1.2
@capacitor/core : 6.1.2
@capacitor/ios : 6.1.2
Utility:
cordova-res : not installed globally
native-run : 2.0.1
System:
NodeJS : v18.20.4 (/Users/.../.nvm/versions/node/v18.20.4/bin/node)
npm : 10.7.0
OS : macOS Unknown
Additional Information
No response
The text was updated successfully, but these errors were encountered: