Skip to content

fix: fix incorrect nav animations #28297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

fix: fix incorrect nav animations #28297

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6aaef02
fix(angular): fix navigation stack when using browser back and forwar…
philipp-stsm Sep 16, 2023
ff2c9f7
fix(angular): remove legacy code for Angular < 7.2.0
philipp-stsm Sep 16, 2023
7c23f9a
fix(angular): update comment
philipp-stsm Sep 16, 2023
c8370d9
fix: apply changes from other branch
philipp-stsm Oct 6, 2023
2c3a529
fix: apply root transition when using root routerLink and browser bac…
philipp-stsm Oct 31, 2023
b07e8d2
chore: revert unnecessary changes and tidy up
philipp-stsm Oct 31, 2023
968a503
fix: fix import
philipp-stsm Oct 31, 2023
b852c9b
fix: small simplification
philipp-stsm Oct 31, 2023
3d16ac1
Merge branch 'main' into fix-incorrect-nav-animations
hoi4 Nov 15, 2023
9027d74
revert: revert changes to test file
philipp-stsm Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: small simplification
  • Loading branch information
@philipp-stsm
philipp-stsm committed Oct 31, 2023
commit b852c9b61c94e255b87962fd71b985a1e4a0e0bb
5 changes: 1 addition & 4 deletions packages/angular/common/src/directives/navigation/stack-controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,10 +94,7 @@ export class StackController {
* This can happen e.g. when navigating to a page with navigateRoot and then using the browser back button
*/
const isPopStateTransitionFromRootPage =
direction === 'back' &&
isDirectionBasedOnNavigationIds &&
leavingView?.root &&
currentNavigation?.trigger === 'popstate';
direction === 'back' && leavingView?.root && currentNavigation?.trigger === 'popstate';

/**
* whether direction based on stack order takes precedence over direction based on navigation ids
Expand Down