-
Notifications
You must be signed in to change notification settings - Fork 13.4k
fix(popover): adjust position to account for approximate safe area #29068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
averyjohnston
wants to merge
13
commits into
main
Choose a base branch
from
FW-5463
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
0d7497a
fix(popover): adjust position to account for approximate safe area
c4918b9
lint
ee626e0
add tests
21b285a
chore(): add updated snapshots
Ionitron 530e723
Merge branch 'feature-7.8' into FW-5463
averyjohnston 6503c60
revert flaky diff
69969e0
fix(popover): adjust position to account for approximate safe area
525a25f
lint
cfac073
add tests
e97811a
chore(): add updated snapshots
Ionitron 6fd0e78
revert flaky diff
fec3b0b
Merge branch 'FW-5463' of https://github.com/ionic-team/ionic-framewo…
6693737
chore(): add updated snapshots
Ionitron File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
add tests
- Loading branch information
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be screenshot tests according to our best practices guide.
(same as below test)