Skip to content

chore(theming): remove Sass default flags #29401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2024
Merged

chore(theming): remove Sass default flags #29401

merged 1 commit into from
Apr 25, 2024

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Apr 25, 2024

Issue number: N/A


What is the current behavior?

Currently, every Sass variable in Ionic has the !default flag added to the end.

From the Sass variables documentation:

Normally when you assign a value to a variable, if that variable already had a value, its old value is overwritten. But if you’re writing a Sass library, you might want to allow your users to configure your library’s variables before you use them to generate CSS.

To make this possible, Sass provides the !default flag. This assigns a value to a variable only if that variable isn’t defined or its value is null. Otherwise, the existing value will be used.

In past versions of Ionic Framework, developers wrote Sass variables to rebuild Ionic Framework using their own values. In the latest versions of Ionic Framework, this is not possible.

What is the new behavior?

Removes the !default flag from all Sass variables.

Does this introduce a breaking change?

  • Yes
  • No

Co-authored-by: brandyscarney [email protected]

Copy link

vercel bot commented Apr 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2024 7:44pm

@github-actions github-actions bot added the package: core @ionic/core package label Apr 25, 2024
@liamdebeasi liamdebeasi changed the title chore: remove default refactor(theming): remove Sass default flags Apr 25, 2024
@liamdebeasi liamdebeasi marked this pull request as ready for review April 25, 2024 19:47
@liamdebeasi liamdebeasi requested a review from a team as a code owner April 25, 2024 19:47
@liamdebeasi liamdebeasi changed the title refactor(theming): remove Sass default flags chore(theming): remove Sass default flags Apr 25, 2024
@liamdebeasi liamdebeasi added this pull request to the merge queue Apr 25, 2024
Merged via the queue into main with commit 6e8bf49 Apr 25, 2024
46 checks passed
@liamdebeasi liamdebeasi deleted the default-sass branch April 25, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants