Skip to content

feat(react): fixing support for react 19, adding test app for react 19 #30217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 3, 2025
Merged

feat(react): fixing support for react 19, adding test app for react 19 #30217

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
dd37803
feat(react): Adding test app for React 19
ShaneK Feb 26, 2025
30b1e7f
fix(testing): adding react19 to the test-react-e2e matrix
ShaneK Feb 26, 2025
22b852e
fix(react): resolve errors with JSX and types
brandyscarney Feb 26, 2025
2f402c0
fix(testing): fixing missing default value in useRef
ShaneK Feb 26, 2025
5824663
Moving tsconfig changes to make them local to react
ShaneK Feb 27, 2025
95adcee
fix(tsconfig): Moving more tsconfig changes to be local to react
ShaneK Feb 27, 2025
fda2e2e
fix(rollup): Seeing if I can make react use local tsconfig
ShaneK Feb 27, 2025
8eee226
fix(lint): removing unused vars, undoing unnecessary change
ShaneK Feb 27, 2025
b5165be
fix(lint): Running lint
ShaneK Feb 27, 2025
460e70b
Merge branch 'feature-8.5' into ROU-11393
ShaneK Feb 28, 2025
d7fb789
Merge branch 'feature-8.5' into ROU-11393
ShaneK Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(lint): Running lint
  • Loading branch information
@ShaneK
ShaneK committed Feb 27, 2025
commit b5165be8bf9be19e62768271c2cf846b7d9bb01d
9 changes: 6 additions & 3 deletions packages/react/src/components/IonApp.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,12 @@ import { IonOverlayManager } from './IonOverlayManager';
import type { IonicReactProps } from './IonicReactProps';
import { IonAppInner } from './inner-proxies';

type Props = PropsWithChildren<LocalJSX.IonApp & IonicReactProps & {
ref?: React.Ref<HTMLIonAppElement>;
}>;
type Props = PropsWithChildren<
LocalJSX.IonApp &
IonicReactProps & {
ref?: React.Ref<HTMLIonAppElement>;
}
>;

export class IonApp extends React.Component<Props> {
addOverlayCallback?: (id: string, overlay: ReactComponentOrElement, containerElement: HTMLDivElement) => void;
Expand Down
9 changes: 6 additions & 3 deletions packages/react/src/components/navigation/IonBackButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,12 @@ import { NavContext } from '../../contexts/NavContext';
import type { IonicReactProps } from '../IonicReactProps';
import { IonBackButtonInner } from '../inner-proxies';

type Props = PropsWithChildren<LocalJSX.IonBackButton & IonicReactProps & {
ref?: React.Ref<HTMLIonBackButtonElement>;
}>;
type Props = PropsWithChildren<
LocalJSX.IonBackButton &
IonicReactProps & {
ref?: React.Ref<HTMLIonBackButtonElement>;
}
>;

export class IonBackButton extends React.Component<Props> {
context!: React.ContextType<typeof NavContext>;
Expand Down
Loading