Skip to content

fix(select): update icon color and use correct focused class #30342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Apr 16, 2025
Merged

fix(select): update icon color and use correct focused class #30342

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
42f16cf
fix(select): use correct focus class for styling
thetaPC Apr 4, 2025
a93adf3
refactor(select): use gray on icon when expanded and in item
thetaPC Apr 4, 2025
c984fa4
refactor(select): update style order
thetaPC Apr 4, 2025
6dbb459
refactor(select): use class and not
thetaPC Apr 4, 2025
f3f3ee1
refactor(select): add extra classes
thetaPC Apr 4, 2025
8976737
refactor(select): clean up styles
thetaPC Apr 4, 2025
06e2034
fix(select): include missing styles
thetaPC Apr 7, 2025
7c6a004
refactor(select): update the styles for no fill
thetaPC Apr 7, 2025
c57530b
test(select): add in item highlight snapshots
thetaPC Apr 7, 2025
428338b
fix(select): use `has-focus` class
thetaPC Apr 10, 2025
7eb647c
fix(select): remove .only
thetaPC Apr 10, 2025
1cd0c14
docs(select): add todo for ion-focusable
thetaPC Apr 11, 2025
d9f8ea6
refactor(select): icon should be gray for has-focus
thetaPC Apr 11, 2025
ed31a7c
fix(select): use text color on valid focus no fill
thetaPC Apr 14, 2025
bb14c4f
test(select): add focus invalid screenshots
thetaPC Apr 14, 2025
ec9251d
refactor(select): use gray for no fill and in item
thetaPC Apr 15, 2025
33ca720
Update core/src/components/select/select.md.solid.scss
thetaPC Apr 15, 2025
db25824
Update core/src/components/select/select.md.outline.scss
thetaPC Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
docs(select): add todo for ion-focusable
  • Loading branch information
@thetaPC
thetaPC committed Apr 11, 2025
commit 1cd0c14e5b7f725ce4d5a8d7c6a22236f1256bd5
2 changes: 2 additions & 0 deletions core/src/components/select/select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1163,6 +1163,8 @@ export class Select implements ComponentInterface {
'label-floating': labelShouldFloat,
'has-placeholder': placeholder !== undefined,
'has-focus': hasFocus,
// TODO(FW-6451): Remove `ion-focusable` class in favor of `has-focus`.
'ion-focusable': true,
[`select-${rtl}`]: true,
[`select-fill-${fill}`]: fill !== undefined,
[`select-justify-${justify}`]: justifyEnabled,
Expand Down
Loading