Skip to content

fix(css): improve tokens support on global css ionic files #30364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 16, 2025

Conversation

BenOsodrac
Copy link
Contributor

@BenOsodrac BenOsodrac commented Apr 16, 2025

Issue number: internal


What is the new behavior?

  • Add tokens usage on global css files for Ionic theme.
  • Removed global background an text variables and fixed variables names used on body. This resulted in some changes on test pages colors, hence the snapshots differences.

Does this introduce a breaking change?

  • Yes
  • No

@BenOsodrac BenOsodrac added package: core @ionic/core package type: bug a confirmed bug report labels Apr 16, 2025
Copy link

vercel bot commented Apr 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 16, 2025 2:06pm

@BenOsodrac BenOsodrac changed the title fix(css): improve tokens support on global css ionic theme files fix(css): improve tokens support on global css ionic files Apr 16, 2025
@BenOsodrac BenOsodrac marked this pull request as ready for review April 16, 2025 14:18
@BenOsodrac BenOsodrac requested a review from a team as a code owner April 16, 2025 14:18
@BenOsodrac BenOsodrac requested review from thetaPC and brandyscarney and removed request for thetaPC April 16, 2025 14:18
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@BenOsodrac BenOsodrac merged commit 1e7a84f into next Apr 16, 2025
49 checks passed
@BenOsodrac BenOsodrac deleted the ROU-11814-css-global branch April 16, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants