Skip to content

fix(item): emit click event once when clicking padded space on item and emit correct element #30373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Apr 30, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test(many): add click listener to tests
  • Loading branch information
brandyscarney committed Apr 25, 2025
commit 3cfcf2a4d42d3ee3ad72245e6471af5f55a86d74
10 changes: 10 additions & 0 deletions core/src/components/checkbox/test/item/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,16 @@ <h1>Multiline Label</h1>
</div>
</div>
</ion-content>

<script>
const items = document.querySelectorAll('ion-item');

for (var i = 0; i < items.length; i++) {
items[i].addEventListener('click', function (ev) {
console.log('item clicked', ev.target);
});
}
</script>
</ion-app>
</body>
</html>
10 changes: 10 additions & 0 deletions core/src/components/input/test/item/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -69,5 +69,15 @@ <h2>Inset List</h2>
</div>
</ion-content>
</ion-app>

<script>
const items = document.querySelectorAll('ion-item');

for (var i = 0; i < items.length; i++) {
items[i].addEventListener('click', function (ev) {
console.log('item clicked', ev.target);
});
}
</script>
</body>
</html>
10 changes: 10 additions & 0 deletions core/src/components/radio/test/item/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -207,5 +207,15 @@ <h1>Multiline Label</h1>
</div>
</ion-content>
</ion-app>

<script>
const items = document.querySelectorAll('ion-item');

for (var i = 0; i < items.length; i++) {
items[i].addEventListener('click', function (ev) {
console.log('item clicked', ev.target);
});
}
</script>
</body>
</html>
10 changes: 10 additions & 0 deletions core/src/components/select/test/item/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -83,5 +83,15 @@ <h2>Disabled</h2>
</div>
</ion-content>
</ion-app>

<script>
const items = document.querySelectorAll('ion-item');

for (var i = 0; i < items.length; i++) {
items[i].addEventListener('click', function (ev) {
console.log('item clicked', ev.target);
});
}
</script>
</body>
</html>
10 changes: 10 additions & 0 deletions core/src/components/textarea/test/item/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -69,5 +69,15 @@ <h2>Inset List</h2>
</div>
</ion-content>
</ion-app>

<script>
const items = document.querySelectorAll('ion-item');

for (var i = 0; i < items.length; i++) {
items[i].addEventListener('click', function (ev) {
console.log('item clicked', ev.target);
});
}
</script>
</body>
</html>
10 changes: 10 additions & 0 deletions core/src/components/toggle/test/item/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -224,5 +224,15 @@ <h1>Multiline Label</h1>
</div>
</ion-content>
</ion-app>

<script>
const items = document.querySelectorAll('ion-item');

for (var i = 0; i < items.length; i++) {
items[i].addEventListener('click', function (ev) {
console.log('item clicked', ev.target);
});
}
</script>
</body>
</html>