Skip to content

fix(link): improve ionic theme links styles and dev experience #30375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 30, 2025
Merged

fix(link): improve ionic theme links styles and dev experience #30375

merged 9 commits into from
Apr 30, 2025

Conversation

BenOsodrac
Copy link
Contributor

@BenOsodrac BenOsodrac commented Apr 29, 2025 •
edited by thetaPC
Loading

Issue number: internal

What is the new behavior?

  • Adjust link styles to match latest Figma UI and tokens.
  • For default link, make it work without the need of adding a class.
  • Change ionic to ion on the class names.
  • Adjusted tests to reflect the changes.

Does this introduce a breaking change?

  • [] Yes
  • No

Other information

@BenOsodrac BenOsodrac added package: core @ionic/core package type: bug a confirmed bug report labels Apr 29, 2025
@vercel Vercel
Copy link

vercel bot commented Apr 29, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2025 3:13pm

@BenOsodrac BenOsodrac marked this pull request as ready for review April 29, 2025 14:20
@BenOsodrac BenOsodrac requested a review from a team as a code owner April 29, 2025 14:20
@BenOsodrac BenOsodrac requested review from ShaneK and thetaPC and removed request for ShaneK April 29, 2025 14:20
@thetaPC
Copy link
Contributor

thetaPC commented Apr 29, 2025

@BenOsodrac I updated the breaking change to be "no" since it doesn't change anything related to ios or md. Since ionic theme hasn't been released to main, then changes to ionic are not considered breaking changes.

@BenOsodrac
Copy link
Contributor Author

@BenOsodrac I updated the breaking change to be "no" since it doesn't change anything related to ios or md. Since ionic theme hasn't been released to main, then changes to ionic are not considered breaking changes.

Ah good to know 👍 , I always treated the ones on Ionic as possible breaking-changes on our own code or OS side.

@BenOsodrac BenOsodrac requested a review from thetaPC April 30, 2025 10:21
thetaPC
thetaPC approved these changes Apr 30, 2025
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BenOsodrac BenOsodrac merged commit b2f6b8c into next Apr 30, 2025
48 checks passed
@BenOsodrac BenOsodrac deleted the ROU-11850 branch April 30, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandyscarney brandyscarney brandyscarney approved these changes

@thetaPC thetaPC thetaPC approved these changes

Assignees
No one assigned
Labels
package: core @ionic/core package type: bug a confirmed bug report
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BenOsodrac @thetaPC @brandyscarney @Ionitron