Skip to content

fix(header, content): update colors for ionic theme #30489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Conversation

joselrio
Copy link
Contributor

@joselrio joselrio commented Jun 16, 2025

Issue number: resolves #


What is the current behavior?

  • The colors were not working on Header and Content when used inside a modal;

What is the new behavior?

  • Added the class selector in-modal to header and content when used inside the modal.
  • Through the added selector, just set the same variable value used under the modal context.

Does this introduce a breaking change?

  • Yes
  • No

Other information

https://ionic-framework-git-rou-11977-ionic1.vercel.app/src/components/modal/test/basic?ionic:theme=ionic

@joselrio joselrio requested a review from a team as a code owner June 16, 2025 16:26
@joselrio joselrio requested a review from gnbm June 16, 2025 16:26
Copy link

vercel bot commented Jun 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2025 11:58pm

@github-actions github-actions bot added the package: core @ionic/core package label Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants