This repository was archived by the owner on Nov 4, 2021. It is now read-only.
chore(tsify): upgrade tsify version to 1.0.1
#43
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current version of browserify-typescript is using tsify@^0.14.1 which is incompatible with @types from TypeScript 2.0. A fix has been created in tsify@^1.0.1. By upgrading the package.json with tsify@^1.0.1, TypeScript becomes a devDependency and it is not installed by tsify anymore. TypeScript will have to be installed via npm install typescript --save-dev in your project to use whatever version you want. fix ionic-team#42
|
@brandyscarney is there a reason why this is not merged yet? |
|
I think we're going to hold off on this right now. We're currently in the process of reworking the build process and this will eventually not be an issue. |
|
I just wanted to add that this would also fix ignoring comments in tsconfig.json. Currently, while typescript itself allows comments, tsify didn't until it switched to using the tsconfig module in a later version. Unfortunately, the new ionic-app-scripts based build process fails to process comments in tsconfig.json as well :-( UPDATE: created an ionic-app-scripts issue for it: ionic-team/ionic-app-scripts#18 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of browserify-typescript is using tsify@^0.14.1
which is incompatible with @types from TypeScript 2.0. A fix has been
created in tsify@^1.0.1.
By upgrading the package.json with tsify@^1.0.1, TypeScript becomes a
devDependency and it is not installed by tsify anymore. TypeScript will
have to be installed via npm install typescript --save-dev in your
project to use whatever version you want.
fix #42