Skip to content

Add observation unittests #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 24, 2023
Merged

Add observation unittests #567

merged 2 commits into from
Nov 24, 2023

Conversation

@Danielius1922
Copy link
Member

@Danielius1922 Danielius1922 commented Nov 16, 2023

No description provided.

@ocf-conformance-test-tool
Copy link

ocf-conformance-test-tool bot commented Nov 16, 2023

🎉 Thank you for your code contribution! To guarantee the change/addition is conformant to the OCF Specification, we would like to ask you to execute OCF Conformance Testing of your change ☝️ when your work is ready to be reviewed.

ℹ️ To verify your latest change (4fceec7), label this PR with OCF Conformance Testing.

⚠️ Label is removed with every code change.

@Danielius1922 Danielius1922 force-pushed the adam/feature/observation-unittests branch 9 times, most recently from f529898 to 01d599c Compare November 18, 2023 19:42
@Danielius1922 Danielius1922 force-pushed the adam/feature/observation-unittests branch 8 times, most recently from 95230f1 to 33b974f Compare November 21, 2023 16:10
@Danielius1922 Danielius1922 added OCF Conformance Testing OCF Conformance Testing required and removed OCF Conformance Testing OCF Conformance Testing required labels Nov 21, 2023
@SiMet SiMet added OCF Conformance Testing OCF Conformance Testing required and removed OCF Conformance Testing OCF Conformance Testing required labels Nov 22, 2023
@SiMet
Copy link
Collaborator

SiMet commented Nov 22, 2023

@Danielius1922 I'm getting build error:

14:33:07 [Automation] gcc -c -o obj/server/transactions.o ../../messaging/coap/transactions.c -fPIC -fno-asynchronous-unwind-tables -fno-omit-frame-pointer -ffreestanding -Os -fno-stack-protector -ffunction-sections -fdata-sections -fno-reorder-functions -fno-defer-pop -fno-strict-overflow -I./ -I../../include/ -I../../ -I../../deps/tinycbor/src -I../../api -std=gnu99 -Wall -Wextra -Werror -Wno-error=deprecated-declarations -pedantic  -Wl,--gc-sections -I../../deps/mbedtls/include -Wno-error=unused  -DOC_DNS_LOOKUP_IPV6 -DOC_COLLECTIONS_IF_CREATE -DOC_MNT -DOC_WKCORE -DOC_PKI -DOC_DYNAMIC_ALLOCATION -DOC_INTROSPECTION -DOC_IDD_API -DOC_SOFTWARE_UPDATE -DOC_SECURITY -DOC_OSCORE -DOC_TCP -DOC_SERVER
14:33:07 [Automation] gcc -c -o obj/server/tcpsession.o tcpsession.c -fPIC -fno-asynchronous-unwind-tables -fno-omit-frame-pointer -ffreestanding -Os -fno-stack-protector -ffunction-sections -fdata-sections -fno-reorder-functions -fno-defer-pop -fno-strict-overflow -I./ -I../../include/ -I../../ -I../../deps/tinycbor/src -I../../api -std=gnu99 -Wall -Wextra -Werror -Wno-error=deprecated-declarations -pedantic  -Wl,--gc-sections -I../../deps/mbedtls/include -Wno-error=unused  -DOC_DNS_LOOKUP_IPV6 -DOC_COLLECTIONS_IF_CREATE -DOC_MNT -DOC_WKCORE -DOC_PKI -DOC_DYNAMIC_ALLOCATION -DOC_INTROSPECTION -DOC_IDD_API -DOC_SOFTWARE_UPDATE -DOC_SECURITY -DOC_OSCORE -DOC_TCP -DOC_SERVER
14:33:07 [Automation] In file included from ../../include/oc_helpers.h:32,
14:33:07 [Automation]                  from ../../include/oc_endpoint.h:25,
14:33:07 [Automation]                  from ../../api/oc_endpoint_internal.h:22,
14:33:07 [Automation]                  from tcpsession.c:24:
14:33:07 [Automation] /usr/include/stdio.h:314:6: error: unknown type name �_IO_cookie_io_functions_t’
14:33:07 [Automation]   314 |      _IO_cookie_io_functions_t __io_funcs) __THROW __wur;
14:33:07 [Automation]       |      ^~~~~~~~~~~~~~~~~~~~~~~~~
14:33:07 [Automation] Makefile:455: recipe for target 'obj/server/tcpsession.o' failed
14:33:07 [Automation] make: *** [obj/server/tcpsession.o] Error 1

@Danielius1922
Copy link
Member Author

Danielius1922 commented Nov 22, 2023

@Danielius1922 I'm getting build error:

14:33:07 [Automation] gcc -c -o obj/server/transactions.o ../../messaging/coap/transactions.c -fPIC -fno-asynchronous-unwind-tables -fno-omit-frame-pointer -ffreestanding -Os -fno-stack-protector -ffunction-sections -fdata-sections -fno-reorder-functions -fno-defer-pop -fno-strict-overflow -I./ -I../../include/ -I../../ -I../../deps/tinycbor/src -I../../api -std=gnu99 -Wall -Wextra -Werror -Wno-error=deprecated-declarations -pedantic  -Wl,--gc-sections -I../../deps/mbedtls/include -Wno-error=unused  -DOC_DNS_LOOKUP_IPV6 -DOC_COLLECTIONS_IF_CREATE -DOC_MNT -DOC_WKCORE -DOC_PKI -DOC_DYNAMIC_ALLOCATION -DOC_INTROSPECTION -DOC_IDD_API -DOC_SOFTWARE_UPDATE -DOC_SECURITY -DOC_OSCORE -DOC_TCP -DOC_SERVER
14:33:07 [Automation] gcc -c -o obj/server/tcpsession.o tcpsession.c -fPIC -fno-asynchronous-unwind-tables -fno-omit-frame-pointer -ffreestanding -Os -fno-stack-protector -ffunction-sections -fdata-sections -fno-reorder-functions -fno-defer-pop -fno-strict-overflow -I./ -I../../include/ -I../../ -I../../deps/tinycbor/src -I../../api -std=gnu99 -Wall -Wextra -Werror -Wno-error=deprecated-declarations -pedantic  -Wl,--gc-sections -I../../deps/mbedtls/include -Wno-error=unused  -DOC_DNS_LOOKUP_IPV6 -DOC_COLLECTIONS_IF_CREATE -DOC_MNT -DOC_WKCORE -DOC_PKI -DOC_DYNAMIC_ALLOCATION -DOC_INTROSPECTION -DOC_IDD_API -DOC_SOFTWARE_UPDATE -DOC_SECURITY -DOC_OSCORE -DOC_TCP -DOC_SERVER
14:33:07 [Automation] In file included from ../../include/oc_helpers.h:32,
14:33:07 [Automation]                  from ../../include/oc_endpoint.h:25,
14:33:07 [Automation]                  from ../../api/oc_endpoint_internal.h:22,
14:33:07 [Automation]                  from tcpsession.c:24:
14:33:07 [Automation] /usr/include/stdio.h:314:6: error: unknown type name �_IO_cookie_io_functions_t’
14:33:07 [Automation]   314 |      _IO_cookie_io_functions_t __io_funcs) __THROW __wur;
14:33:07 [Automation]       |      ^~~~~~~~~~~~~~~~~~~~~~~~~
14:33:07 [Automation] Makefile:455: recipe for target 'obj/server/tcpsession.o' failed
14:33:07 [Automation] make: *** [obj/server/tcpsession.o] Error 1

Seems to be related to __USE_GNU, let me try moving it before the first include (oc_features.h), I thought it was not necessary but it includes the linux version config.h, which includes some standand header, so that might be causing the issue.

@Danielius1922 Danielius1922 force-pushed the adam/feature/observation-unittests branch from 33b974f to ec84cae Compare November 22, 2023 14:07
@ocf-conformance-test-tool ocf-conformance-test-tool bot removed the OCF Conformance Testing OCF Conformance Testing required label Nov 22, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 22, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

78.8% 78.8% Coverage
0.9% 0.9% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@Danielius1922 Danielius1922 added the OCF Conformance Testing OCF Conformance Testing required label Nov 23, 2023
@Danielius1922 Danielius1922 marked this pull request as ready for review November 23, 2023 11:36
jkralik
jkralik approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@jkralik jkralik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! :)

@Danielius1922 Danielius1922 merged commit 4eec81c into master Nov 24, 2023
@Danielius1922 Danielius1922 deleted the adam/feature/observation-unittests branch November 24, 2023 13:53
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkralik jkralik jkralik approved these changes

Assignees

No one assigned

Labels

OCF Conformance Testing OCF Conformance Testing required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Danielius1922 @SiMet @jkralik