Better testing of workouts using slices instead of maps, use single style for point creation. #18
Conversation
…tyle for point creation. - tags and fields will always be output in the same order. - store fields and tags as slices instead of maps - reorder test fixtures and output as necessary - Create points the same, in the more fluent style - add static tags to sleep metrics again
|
I'll hold off reviewing this until #17 is merged since that is a dependency - it'll make it easier to sift through the new changes. Thanks for the effort! |
|
Hey @tedpearson, if you're still interested in working on this PR, you can rebase your changes onto the latest |
|
Weird. I thought I had already done so! 😂 Must have forgotten. Ready for review now. |
Codecov ReportBase: 70.90% // Head: 71.93% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
==========================================
+ Coverage 70.90% 71.93% +1.03%
==========================================
Files 7 7
Lines 622 620 -2
==========================================
+ Hits 441 446 +5
+ Misses 143 139 -4
+ Partials 38 35 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
LGTM, you can merge when you are ready~ |
This PR was begun almost a week ago and I just finished it up tonight. It may be a bit rough around the edges, and you may or may not want to move in this direction, so rejection/disagreements will be fine here.
I started this out wanting to have a single fluent style for point creation. This resulted in failing tests due to map iteration order, so I ended up changing both tags and fields to use slices instead of maps internally. I also realized I missed adding static tags to sleep metrics, so this adds them. I don't have a full grasp of the changes right now as it's late and it's been several days since I began, so it might take a bit of extra work to resolve any comments.
Summary: