Fix ansible lint issues in rabbitmq_ssl role #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvelarde-itential
requested review from
Madias2222,
Nick-Andreano and
steven-schattenberg-itential
steven-schattenberg-itential
approved these changes
Sep 10, 2024
kvelarde-itential
added a commit
that referenced
this pull request
Sep 13, 2024
* Fix lint issues in os role (#45) * Fix lint issues in vault role(#46) * Fix lint issues in redis_replication role (#47) * Fix lint issues in redis auth role (#48) * Fix lint issues in platform_app_artifact role (#49) * Fix lint issues in rabbitmq_ssl role (#50) * Fix lint issues in python role (#51) * Fix lint issues in offline role (#52) * Fix lint issues in redis role (#53) * Fix lint issues in rabbit_cluster role (#55) * Fix lint issues in rabbit role (#56) * Fix lint issues in playbooks (#57) * Fix lint issues in platform role (#59) * Fix lint issues in common_vars role (#60) * Change yum tasks to dnf (#62) --------- Co-authored-by: Steven Schattenberg <[email protected]> Co-authored-by: Nick-Andreano <[email protected]>
steven-schattenberg-itential
added a commit
that referenced
this pull request
Sep 21, 2024
* Ansible lint (#46) * resolved conflicts * Fix ansible-lint issues * Resolved conflict * Os (#45) * Remove yum_update and remove the task to update the current yum packages --------- Co-authored-by: $GITHUB_ACTOR <[email protected]> * Fix ansible lint issues in redis auth role (#48) * Fix lint issues in redis_auth role * Fix ansible lint issues in platform_app_artifact role (#49) * Fix ansible lint issues in python role (#51) * Fix ansible lint issues in rabbitmq_ssl role (#50) * Add RabbitMQ custom configuration tasks * Move rabbitmq cluster role tasks to rabbitmq role Remove rabbitmq cluster role Update docs Fix hard-coded rabbitmq ports in platform role Move rabbitmq ports to common vars role Add ability to set rabbitmq disk_free_limit.absolute * Support non-standard mongo port (#65) * resolved conflicts * Adding port var to mongo tasks to support non-standard ports * Fixed typo * Resolved code review items * Fixed redis installation when using custom variables (#66) * Create redis_varlib.te This file will add SELinux context to add log, data directories in a different place from the default * Update main.yml to support redis_data_dir, redis_log_dir, redis_pid_dir, different port Fix support to: * redis_data_dir, * redis_log_dir, * redis_pid_dir, * different port * Remove user,group and data,log directories creation. Remove user,group and data,log directories creation. Those items now are created in main.yml tasks * Fixed pid dir, and announce port Fixed pid dir, and announce port * Change the installation source from remi_repo to source Change the installation source from remi_repo to source * Added redis_port and sentinel_port variables Added redis_port and sentinel_port variables * Fixed the hardcoded redis ports to variable Fixed the hardcoded redis ports to variable * Fixed source install Fixed source install * Fixed conditions rules for execute directories creation Fixed conditions rules for execute directories creation * Optimize the code in announce items Optimize the code in announce items * Removed sentinel port, moved for common vars Removed sentinel port, moved for common vars * Fixed the hardcoded redis port to a variable Fixed the hardcoded redis port to a variable * Fixed hardcoded ports to variable Fixed hardcoded ports to variable * Fix sentinel variable name Fix sentinel variable name * Fixed trailing spaces Fixed trailing spaces * Fix ansible lint issue in redis * Fix spacing in RabbitMQ guide --------- Co-authored-by: Steven Schattenberg <[email protected]> Co-authored-by: Nick-Andreano <[email protected]> Co-authored-by: $GITHUB_ACTOR <[email protected]> Co-authored-by: Marcos Dias <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.