Skip to content

Build pkg standalone binaries for more platforms #954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 14, 2022
Merged

Build pkg standalone binaries for more platforms #954

merged 7 commits into from
Apr 14, 2022

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented Apr 12, 2022 •
edited
Loading

Required for iterative/setup-cml#57 and iterative/setup-cml#60 (comment). Bring sanity back to artifact names without introducing any breaking change. 🎉

Tests are broken because they run on pull_request_target with the old workflow

@0x2b3bfa0 0x2b3bfa0 added enhancement New feature or request p1-important High priority binary labels Apr 12, 2022
@0x2b3bfa0 0x2b3bfa0 self-assigned this Apr 12, 2022
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal April 12, 2022 23:44 Inactive
@0x2b3bfa0 0x2b3bfa0 requested a review from a team April 14, 2022 14:03
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal April 14, 2022 14:08 Inactive
0x2b3bfa0
0x2b3bfa0 commented Apr 14, 2022
View reviewed changes
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal April 14, 2022 14:13 Inactive
@0x2b3bfa0
Copy link
Member Author

@iterative/cml, may I?

@0x2b3bfa0 0x2b3bfa0 enabled auto-merge (squash) April 14, 2022 14:31
@0x2b3bfa0 0x2b3bfa0 marked this pull request as draft April 14, 2022 14:33
auto-merge was automatically disabled April 14, 2022 14:33

Pull request was converted to draft

0x2b3bfa0
0x2b3bfa0 commented Apr 14, 2022
View reviewed changes
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal April 14, 2022 14:44 Inactive
@0x2b3bfa0 0x2b3bfa0 marked this pull request as ready for review April 14, 2022 14:46
@0x2b3bfa0
Copy link
Member Author

Self–merging as per this message. Tests run on pull_request_target and won't pass until the branch is merged.

@0x2b3bfa0 0x2b3bfa0 merged commit e51531f into master Apr 14, 2022
@0x2b3bfa0 0x2b3bfa0 deleted the windows-standalone branch April 14, 2022 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@0x2b3bfa0 0x2b3bfa0

Labels
enhancement New feature or request p1-important High priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@0x2b3bfa0