Skip to content

fix: non ASCII env build fail #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 5, 2018
Merged

fix: non ASCII env build fail #43

merged 1 commit into from
Jul 5, 2018

Conversation

RexQian
Copy link

@RexQian RexQian commented Jul 5, 2018 •
edited
Loading

build failed when env variable contains non ASCII
error message: Gradle build daemon disappeared unexpectedly
ref #39

reproduce:

  • submit commit with a non ascii comment (CI_COMMIT_MESSAGE)
  • or GITLAB_USER_NAME contains non ascii

@jangrewe
Copy link
Owner

jangrewe commented Jul 5, 2018 •
edited
Loading

I wouldn't have anything to quickly test it with, so for now i'll do a blind trust merge as it looks like a sane idea ;-)

@jangrewe jangrewe merged commit 6097834 into jangrewe:master Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RexQian @jangrewe