Search modal #6760
Search modal #6760
Conversation
- Removes the inline search input and results display - Adds a button that triggers a modal dialog for search - Maintains existing search functionality via the modal
**Changes:** - Adds a search dialog component with support for: - Query matching across thread titles, messages, and metadata - Dynamic result filtering with real-time updates - Contextual snippets highlighting query matches - Date-based sorting using most recent activity **Implementation Details:** - Uses memoized computations for performance optimization - Handles diverse date formats (timestamps, ISO strings, Date objects) - Implements case-insensitive matching with substring search - Includes proper type handling for thread data structures **Integration:** - Connects to existing thread store via useThreads hook - Maintains compatibility with current routing system - Follows established UI patterns for dialog components
- Matches mockups for: * Filter dropdowns (projects/dates) * Search result snippets with highlighting * Calendar picker interaction flows
There was a problem hiding this comment.
Pull Request Overview
This PR implements a modal-based search interface to replace the inline search input bar, adding filtering capabilities for date ranges and projects with enhanced UI and localization support.
- Replaced inline search input with a search button that opens a dedicated modal dialog
- Added comprehensive date range filtering with a custom calendar picker component
- Integrated project-based filtering with multi-select dropdown functionality
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| web-app/src/containers/dialogs/SearchDialog.tsx | New search modal component with date picker, project filters, and result highlighting |
| web-app/src/containers/LeftPanel.tsx | Replaced inline search input with search button that opens the modal |
| web-app/src/locales/*/common.json | Added translations for new search functionality (clear, filterByProject, filterByDate, selected) |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Hi @Infuseting, personally I still think the simple search bar seems more useful for lots of users if they do not have too many conversations/projects. Let's head for simplicity for most AI users, while leaving the advanced features optional for power user in deeper settings/extended configs. |
|
It can be a way to implement it. |
2 participants
Describe Your Changes
Implement search dialog instead of search input bar with filter like date and project.
Fixes Issues
Self Checklist