Skip to content

Template element #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 25, 2025
Merged

Template element #368

merged 5 commits into from
Apr 25, 2025

Conversation

samanzameni
Copy link
Contributor

Template element

@samanzameni
Update article.md
286b23d 
Template element
@javascript-translate-bot javascript-translate-bot requested a review from a team April 21, 2025 14:07
mahdyar
mahdyar requested changes Apr 23, 2025
View reviewed changes
Copy link
Member

@mahdyar mahdyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the article title as your PR title. Read #1.

8-web-components/4-template-element/article.md Outdated
@@ -1,13 +1,14 @@

# Template element
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please translate the title somehow so it'll be obvious in the site that it's been translated.

@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

3 similar comments
@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@javascript-translate-bot
Copy link

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@samanzameni
Copy link
Contributor Author

/done

@javascript-translate-bot javascript-translate-bot requested a review from a team April 25, 2025 11:02
@mahdyar mahdyar changed the title article.md Template element Apr 25, 2025
mahdyar
mahdyar approved these changes Apr 25, 2025
View reviewed changes
Copy link
Member

@mahdyar mahdyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @samanzameni!

@mahdyar mahdyar merged commit f152ed3 into javascript-tutorial:master Apr 25, 2025
1 check passed
@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

@javascript-translate-bot
Copy link

Error: the article already translated in the Progress Issue #1 ⁉️

1 similar comment
@javascript-translate-bot
Copy link

Error: the article already translated in the Progress Issue #1 ⁉️

@javascript-translate-bot
Copy link

Thank you 💖 I updated the Progress Issue #1 🎉 🎉 🎉

@javascript-translate-bot javascript-translate-bot mentioned this pull request Apr 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahdyar mahdyar mahdyar approved these changes

Assignees
No one assigned
Labels
needs +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samanzameni @javascript-translate-bot @mahdyar