-
-
Notifications
You must be signed in to change notification settings - Fork 207
Settings for delays between emails, batches and the size of batches. #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hey @jorenham, Thanks for an awesome contrib. Code looks good, though I think it is important to stress that also sub-second delays can be used. Sending 10k emails with 1 second delay is not really feasable. ;) It would be great, though to also have coverage here. Basically, you mock out Mathijs |
|
Very well done, thanks! LGTM except for one issue: settings in tests need to be overridden in a different way. See for example here: https://github.com/dokterbob/django-newsletter/blob/9d4b93ac875f91fcb9c4938fb3ffccd5b85dea8a/tests/test_web.py#L646 Or look at the Django docs on this topic here https://docs.djangoproject.com/en/1.8/topics/testing/tools/#overriding-settings. Lastly, you've used Python 3's built-in mock, which is unavailable on 2.7. You need to add the |
|
I see |
|
Yep.
|
|
Thanks! |
For sending out large amounts of emails, it is generally a good idea to send them out in batches. This way your email servers aren't flooded and can recover in between batches.