Fix an UnboundLocalError if a compiler fails. #541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depending on where an exception is raised inside a compiler's `execute_command`, the `stdout` variable may not be assigned. In this case, the finally handler would fail with an `UnboundLocalError`, hiding the true cause of the exception. This change adds a new variable, `stdout_name`, which is populated once we've actually created the file. After this, the `CompilerError` is successfully raised with the contents of the true error.
|
A quick note to the maintainer that I included the fix for this in my compiler/compressor unit tests pull request (#531) in commit theatlantic@9d7c6c0 . If this gets merged it will create a merge conflict, so I'll keep an eye out (as that would be relatively easy to resolve). |
|
Oops. Thanks for the fix. 🏃 🌲 |
Pull request 531, among many other things, includes a similar fix for the use of `stdout` before it's been assigned. That implementation is a nicer read, so I've switched over to it.
davidt
added a commit
that referenced
this pull request
Feb 22, 2016
Fix an UnboundLocalError if a compiler fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on where an exception is raised inside a compiler's
execute_command, thestdoutvariable may not be assigned. In this case, thefinally handler would fail with an
UnboundLocalError, hiding the true causeof the exception. This change adds a new variable,
stdout_name, which ispopulated once we've actually created the file. After this, the
CompilerErroris successfully raised with the contents of the true error.