Skip to content

Fix temporary file permissions #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 11, 2019
Merged

Fix temporary file permissions #675

merged 2 commits into from
Jan 11, 2019

Conversation

mharju
Copy link
Contributor

@mharju mharju commented Nov 22, 2018

Fixes #525. Do you also require tests or other stuff for this PR to be accepted?

@coveralls
Copy link

coveralls commented Nov 22, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at ?% when pulling eb345dd on taiste:bug/525-file-permissions-issue into 5ec6801 on jazzband:master.

@DmytroLitvinov
Copy link

DmytroLitvinov commented Dec 15, 2018 •
edited
Loading

Will be it merged?
Ping @hsiaoyi0504

@RDIL RDIL merged commit 4ad598b into jazzband:master Jan 11, 2019
@jezdez
Copy link
Member

jezdez commented Jan 13, 2019

@RDIL This should not have been merged, since it's obviously missing tests. Please revert or add tests.

@mharju Yes, this needs tests.

@RDIL RDIL mentioned this pull request Jan 13, 2019
Merged
@mharju mharju deleted the bug/525-file-permissions-issue branch January 15, 2019 12:44
@mharju mharju restored the bug/525-file-permissions-issue branch May 14, 2019 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mharju @coveralls @DmytroLitvinov @jezdez @RDIL