fixed #522; broken check in theme processing

[BrianAdams]

This appeared to be a simple missing object qualifier for the short circuit logic. Added it in.

[jdorn]

matchKey is defined at the top of that file. Did the current code cause an error for you?

[BrianAdams]

Yes. If the element (in my case a document fragment) is being evaluated as does not have a matchkey function defined, the code crashes with element.matchkey being undefined. To your point the matchkey variable that was originally being checked for existence is defined above which is why I am assuming it was guard code that was guarding the wrong thing. Matckey vs element.matchkey.

[aneesv]

👍

[jdorn]

I still don't quite get what the original error was. Do you have an example schema/code that replicates it?

In your code, elem.matchKey will always be undefined and that if block will never be reached. If you change it to elem[matchKey] instead, it should behave as expected.

[BrianAdams]

Thanks for the catch. The problem is that the code crashes if it processes an element that does not have the function specified in matchkey. In this case, a "document fragment' element is getting iterated over, and is does not have a matching function nor a ParentNode.

[piascikj]

👍

[piascikj]

Woot!