Add new options: #549
Merged
Add new options: #549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* disable_array_delete_all_rows: hides the button to delete all rows in an array. Note that "disable_array_delete:true" over-rides "disable_array_delete_all_rows:false". * disable_array_delete_last_row: hides the button to delete the last row in an array. Note that "disable_array_delete:true" over-rides "disable_array_delete_last_rows:false". * disable_add_properties: hides the button to add properties.
| // If there are minItems items in the array, hide the delete button beneath the rows | ||
| if(minItems || this.hide_delete_buttons) { | ||
| // If there are minItems items in the array, or configured to hide the delete_last_row button, hide the delete button beneath the rows | ||
| if(minItems || this.hide_delete_buttons || this.hide_delete_last_row_buttons) { |
There was a problem hiding this comment.
Can't you just check if(minItems || this.hide_delete_last_row_buttons)? Also checking for this.hide_delete_buttons seems redundant.
There was a problem hiding this comment.
this.hide_delete_buttons hides all of the delete buttons, so if that flag is set, the programmer doesn't need to set this.hide_delete_last_row_buttons.
If the programmer hast set neither this.hide_delete_buttons nor this.hide_delete_all_rows_buttons, and has set this.hide_delete_last_row_buttons, then it will hide the delete-last-row button, but will display the delete-all-rows button
jdorn
added a commit
that referenced
this pull request
Apr 13, 2016
Closes #549 Conflicts: src/editors/array.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
array. Note that "disable_array_delete:true" over-rides
"disable_array_delete_all_rows:false".
array. Note that "disable_array_delete:true" over-rides
"disable_array_delete_last_rows:false".