fix(spotbugs) Added an exclusion file for SpotBugs.

[gounthar]

As #131 was risky (thanks, @MarkEWaite), here is another approach.
We're using an exclusion file.

What has been done

Move to 4.80.
https://github.com/jenkinsci/plugin-pom/releases/tag/plugin-4.77
https://github.com/jenkinsci/plugin-pom/releases/tag/plugin-4.78
https://github.com/jenkinsci/plugin-pom/releases/tag/plugin-4.79
https://github.com/jenkinsci/plugin-pom/releases/tag/plugin-4.80

I changed 3 files ending with CRLF into LF (as SpotBugs was unhappy about that).

[INFO] There are 3 errors reported by Checkstyle 9.3 with /mnt/c/support/users/dev/jenkins/plugins/plot-plugin/checkstyle/checkstyle.xml ruleset.
[ERROR] src/main/java/hudson/plugins/plot/MatrixPlotPublisher.java:[1] (misc) NewlineAtEndOfFile: Expected line ending for file is LF(\n), but CRLF(\r\n) is detected.
[ERROR] src/main/java/hudson/plugins/plot/Plot.java:[1] (misc) NewlineAtEndOfFile: Expected line ending for file is LF(\n), but CRLF(\r\n) is detected.
[ERROR] src/main/java/hudson/plugins/plot/PlotBuilder.java:[1] (misc) NewlineAtEndOfFile: Expected line ending for file is LF(\n), but CRLF(\r\n) is detected.

Added an exclusion file, and referenced it in pom.xml.

[INFO] --- spotbugs:4.8.3.1:check (spotbugs) @ plot ---
[INFO] BugInstance size is 9
[INFO] Error size is 0
[INFO] Total bugs: 9
[ERROR] Medium: Primitive field hudson.plugins.plot.Plot.csvFileName is public and set from inside the class, which makes it too exposed. Consider making it private to limit external accessibility. [hudson.plugins.plot.Plot] At Plot.java:[line 344] PA_PUBLIC_PRIMITIVE_ATTRIBUTE
[ERROR] Medium: Primitive field hudson.plugins.plot.Plot.description is public and set from inside the class, which makes it too exposed. Consider making it private to limit external accessibility. [hudson.plugins.plot.Plot] At Plot.java:[line 352] PA_PUBLIC_PRIMITIVE_ATTRIBUTE
[ERROR] Medium: Primitive field hudson.plugins.plot.Plot.urlNumBuilds is public and set from inside the class, which makes it too exposed. Consider making it private to limit external accessibility. [hudson.plugins.plot.Plot] At Plot.java:[line 516] PA_PUBLIC_PRIMITIVE_ATTRIBUTE
[ERROR] Medium: Primitive field hudson.plugins.plot.Plot.urlStyle is public and set from inside the class, which makes it too exposed. Consider making it private to limit external accessibility. [hudson.plugins.plot.Plot] At Plot.java:[line 476] PA_PUBLIC_PRIMITIVE_ATTRIBUTE
[ERROR] Medium: Primitive field hudson.plugins.plot.Plot.urlTitle is public and set from inside the class, which makes it too exposed. Consider making it private to limit external accessibility. [hudson.plugins.plot.Plot] At Plot.java:[line 464] PA_PUBLIC_PRIMITIVE_ATTRIBUTE
[ERROR] Medium: Primitive field hudson.plugins.plot.Plot.urlUseDescr is public and set from inside the class, which makes it too exposed. Consider making it private to limit external accessibility. [hudson.plugins.plot.Plot] At Plot.java:[line 486] PA_PUBLIC_PRIMITIVE_ATTRIBUTE
[ERROR] Medium: Primitive field hudson.plugins.plot.PlotBuilder.csvSeries is public and set from inside the class, which makes it too exposed. Consider making it private to limit external accessibility. [hudson.plugins.plot.PlotBuilder] At PlotBuilder.java:[line 190] PA_PUBLIC_PRIMITIVE_ATTRIBUTE
[ERROR] Medium: Primitive field hudson.plugins.plot.PlotBuilder.propertiesSeries is public and set from inside the class, which makes it too exposed. Consider making it private to limit external accessibility. [hudson.plugins.plot.PlotBuilder] At PlotBuilder.java:[line 199] PA_PUBLIC_PRIMITIVE_ATTRIBUTE
[ERROR] Medium: Primitive field hudson.plugins.plot.PlotBuilder.xmlSeries is public and set from inside the class, which makes it too exposed. Consider making it private to limit external accessibility. [hudson.plugins.plot.PlotBuilder] At PlotBuilder.java:[line 208] PA_PUBLIC_PRIMITIVE_ATTRIBUTE

How to test

mvn clean verify

Checklist

• Git commits follow best practices
• Build passes in Jenkins
• Appropriate tests or explanation to why this change has no tests
• Pull Request is marked with appropriate label (see .github/release-drafter.yml)
• JIRA issue is well described (problem explanation, steps to reproduce, screenshots)
• For dependency updates: links to external changelogs and, if possible, full diffs

[MarkEWaite]

I pushed changes to only exclude the specific bug pattern and to use the default spotbugs exclusion file name so that no additional entry is needed in pom.xml for the spotbugs file.

[gounthar]

Thank you, @MarkEWaite 👍