Prefer to use config settings in application code over env() calls due to Laravel configuration caching.
#153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…due to Laravel configuration caching.
Nitpick-CI
reviewed
May 21, 2018
config/settings.php
Outdated
| /* | ||
| * ReCaptcha Site Key | ||
| */ | ||
| 'reCaptchSite' => env('RE_CAP_SITE', 'YOURGOOGLECAPTCHAsitekeyHERE'), |
There was a problem hiding this comment.
Expected 1 space after comma in function call; 3 found
Nitpick-CI
reviewed
May 21, 2018
config/settings.php
Outdated
| /* | ||
| * Google Maps API Key | ||
| */ | ||
| 'googleMapsAPIKey' => env('GOOGLEMAPS_API_KEY', 'YOURGOOGLEMAPSkeyHERE'), |
There was a problem hiding this comment.
Expected 1 space after comma in function call; 4 found
Owner
jeremykenedy
left a comment
jeremykenedy
left a comment
There was a problem hiding this comment.
Good call on moving those to a service provider.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor configuration cleanup to be compatible with
php artisan config:cacheif I understand it correctly after coming over this:NOTE: Not tested in any way or form; changes only taken verbatim from a project I am working on, and changed a few other
env()calls I noticed on the way. Adding PR in case it might be useful and the "right way" to do settings like this.