patchpkg: start moving glibc-patch.bash to Go #2237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Start porting the glibc patching script (which has expanded to patching other libraries too) over to Go. To make this change more incremental, this commit only ports copying the original package's files to the patched package (basically the `cp` command). Devbox still runs the embedded bash script until the rest of it is ported. The general patching steps are: - When generating the glibc-patch.nix flake, Devbox gets the absolute path to itself and adds it as a flake input. This makes devbox available in the flake's build. - Instead of running `glibc-patch.bash` as the flake's builder, run `devbox patch <pkg>`.
savil
approved these changes
Aug 29, 2024
| @@ -0,0 +1,156 @@ | |||
| // patchpkg patches packages to fix common linker errors. | |||
There was a problem hiding this comment.
ooh new tongue twister spotted:
how many packages would a patchpkg patch if a patchpkg could patch packages? a patchpkg would patch as many packages as a patchpkg would if a patchpkg could patch packages
| return func(yield func(string, fs.DirEntry) bool) { | ||
| _ = fs.WalkDir(fsys, root, func(path string, d fs.DirEntry, err error) error { | ||
| if err == nil { | ||
| if !yield(path, d) { |
There was a problem hiding this comment.
what is this yield business doing here! Don't besmirch my Small Is Beautiful language
j/k
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start porting the glibc patching script (which has expanded to patching other libraries too) over to Go.
To make this change more incremental, this commit only ports copying the original package's files to the patched package (basically the
cpcommand). Devbox still runs the embedded bash script until the rest of it is ported.The general patching steps are:
glibc-patch.nixflake, Devbox gets the absolute path to itself and adds it as a flake input. This makes devbox available in the flake's build.glibc-patch.bashas the flake's builder, rundevbox patch <pkg>.