bump installed nix version to latest, and update test-nix-versions #2301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeland73
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bumping to 2.24.7 which seems latest tag on https://github.com/NixOS/nix/tags
Our current hardcoded one is fairly old (we should more periodically update this),
and is leading to issues with MacOS Sequoia (see NixOS/nix#11543)
Also add this to the test-nix-versions. I am keeping the older nix versions
around because some of them exercise older nix profile (and other similar issues
that i am failing to recall atm) formats that some users may still be reliant on.
At some point, we should consider bumping up our minimum nix version as well
so we can deprecate legacy nix support (and keep the code base neater).
How was it tested?
@Lagoja is testing this manually
will ensure cicd pass as a sanity test