[cli-test] Added /usr/bin to PATH so that haskell can to verify pkg downloads #2433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savil
approved these changes
Dec 4, 2024
gcurtis
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CICD jobs for
cli-testhas been failing on Haskell example because the PATH (only) in test environment for macos doesn't have access to/usr/bin/securityso it fails to verify TLS handshake on haskell package downloads.This small change ensures haskell has access to security binary.
Broader fix would be to add
/usr/bintosetupPATHfunction that sets up test environments before being run in CICD. But this PR keeps the scope to only the failing test.related to commercialhaskell/stack#4558
How was it tested?
tested in this CI job:
https://github.com/jetify-com/devbox/actions/runs/12147321911