making .es5 files .js files #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeybaker
requested changes
Oct 13, 2016
| @@ -24,7 +24,7 @@ | |||
| "test-server": "babel-tape-runner test/server.jsx | tap-spec", | |||
| "tdd-server": "nodemon -x npm -i node_modules/ -e js,jsx -- run -s test-server", | |||
| "tdd-browser": "mkdir -p .cache; mkdir -p .cache/test; touch .cache/test/browser.js 2> /dev/null; watchify test/browser.jsx --transform babelify --external react/addons --external react/lib/ReactContext --external react/lib/ExecutionEnvironment --debug --outfile .cache/test/browser.js & devtool --watch .cache/test/browser.js --console --browser-field --no-node-timers --show .cache/test/browser.js | faucet", | |||
| "watch": "babel index.js --watch --out-file index.es5", | |||
There was a problem hiding this comment.
This won't work because it'll overwrite the original file!
We should probably just move to a dist and src folder pattern that's become common.
There was a problem hiding this comment.
I'm not sure the watch task ever worked, because the original file was index.jsx, but I'll stick it in src/ as per convention
joeybaker
reviewed
Oct 13, 2016
| @@ -24,7 +24,7 @@ | |||
| "test-server": "babel-tape-runner test/server.jsx | tap-spec", | |||
| "tdd-server": "nodemon -x npm -i node_modules/ -e js,jsx -- run -s test-server", | |||
| "tdd-browser": "mkdir -p .cache; mkdir -p .cache/test; touch .cache/test/browser.js 2> /dev/null; watchify test/browser.jsx --transform babelify --external react/addons --external react/lib/ReactContext --external react/lib/ExecutionEnvironment --debug --outfile .cache/test/browser.js & devtool --watch .cache/test/browser.js --console --browser-field --no-node-timers --show .cache/test/browser.js | faucet", | |||
| "watch": "babel index.js --watch --out-file index.es5", | |||
| "watch": "babel index.js --watch --out-file index.js", | |||
There was a problem hiding this comment.
Oops: this is the part that will overwrite.
|
Ah yeah good spot, I'll fix it when I get near a computer |
|
Can this be merged? |
|
@madole sorry, I missed that you updated things! Merging now. |
joeybaker
approved these changes
Nov 17, 2016
|
Released as 3.0.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.