Skip to content

Conversation

amirsharif
Copy link
Contributor

Methods are deprecated and will either generate an error or a deprecation warning (see: https://stackoverflow.com/questions/69875125/find-element-by-commands-are-deprecated-in-selenium).

All references should be replaced by the relevant By class method (see: https://selenium-python.readthedocs.io/locating-elements.html). This will resolve errors for users on newer versions of chromedriver.

FWIW – interestingly By is already in the import path of all relevant files and inconsistently used throughout. This PR should resolve those confusing inconsistencies as well (e.g. use of both find_element_by_xpath and find_element(By.XPATH in the same class).

@joeyism
Copy link
Owner

joeyism commented Feb 22, 2023

Can you resolve the conflicts? I'll merge it in after it's resolved

@joeyism joeyism merged commit bf1db6e into joeyism:master Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants