Skip to content

Conversation

@joernroeder
Copy link
Contributor

@joernroeder joernroeder commented Sep 25, 2019

this is a follow up of my previous pull request and moves the flexbox styles to the wrapper div to fix alignment of content and buttons.
as i'm not using sass in my project i converted my local changes to the sass styles in the component. please validate behaviour before merging.

@johndatserakis
Copy link
Owner

Ok thanks - I'm going to merge this but I'm not going to push it just yet. I see something wrong that's now been introduced in the bar version. I'll post here when I'm done adjusting that.

@johndatserakis johndatserakis merged commit 6356561 into johndatserakis:master Sep 28, 2019
@johndatserakis
Copy link
Owner

Ok so actually everything was working fine - I just added align-items: center to the wrapper for the bar style. I pushed it, and the new npm version is v5.3.1.

I'm a little confused of your use-case here - I see that the wrapper really only is used for the bar version - is this the intent? In your previous comment you mentioned that you wanted to have more control over the width of the bar content - I might be missing something but couldn't you have just used the cookie__bar class that gets applied to the bar version? Maybe you can just shed a little light here. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants