Skip to content

Fixes issue #45, maybe also #42 #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 16, 2016
Merged

Fixes issue #45, maybe also #42 #50

merged 2 commits into from
Feb 16, 2016

Conversation

qSebastiaNp
Copy link
Contributor

This little patch will fix two bugs, which were introduced with the latest commits:

  • fixes the error with selectedIds.join(), where selectedIds is undefined on non-bulk-deletes
  • fixes opening the modal twice but closing it only once, so a black backdrop and a loading dialog will stay after deleting a row

@qSebastiaNp
Fix ModalRemote.js
aac0c06 
* fixes hanging loading screen
* fixes selectedIds undefined
@qSebastiaNp
Match new version of ModalRemote.js
9e603d0
johnitvn added a commit that referenced this pull request Feb 16, 2016
@johnitvn
Merge pull request #50 from qSebastiaNp/master
5100474 
Fixes issue #45, maybe also #42
@johnitvn johnitvn merged commit 5100474 into johnitvn:master Feb 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qSebastiaNp @johnitvn