Skip to content

Updated component examples. #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2025
Merged

Updated component examples. #428

merged 1 commit into from
Mar 4, 2025

Conversation

ceford
Copy link
Collaborator

@ceford ceford commented Mar 4, 2025

I felt these two articles lacked screenshots of the installed components so I provided them and revised the first section of each for readability.

@HLeithner
Copy link
Member

I would prefere to have them autogenerates with cypress, so it gets' automatically updates on new joomla releases, maybe with some help from @muhme ?

@ceford
Copy link
Collaborator Author

ceford commented Mar 4, 2025

I would prefere to have them autogenerates with cypress, so it gets' automatically updates on new joomla releases, maybe with some help from @muhme ?

I think I know how to do that. But there are 262 images in _assets folders. 182 of them are jpeg but mostly ought to be png. 80 are png. That is too big a problem for me!

@HLeithner
Copy link
Member

It's a "vision" to have the images generated automatically, so if we can start somewhere it would be great

@ceford
Copy link
Collaborator Author

ceford commented Mar 4, 2025

In my count figures I unintentionally included versioned docs. In the latest docs there are only 31 png files and 39 jpg files. Many of them are not Joomla screenshots and/or have annotations such as arrows or circles.

I ran into problems in my adventures with Playwright. It was fine for Help screenshots but tutorials required tailored Joomla installations that I did not have time to script (in many languages). I did do a few.

In this case could you set the "vision" aside and merge this PR?

@HLeithner
Copy link
Member

of course

@HLeithner HLeithner merged commit d7c0e9e into joomla:main Mar 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants