Skip to content
This repository was archived by the owner on Oct 8, 2021. It is now read-only.

Listview grid - created demo illustrating how it could work #5183

Closed
wants to merge 3 commits into from
Closed

Listview grid - created demo illustrating how it could work #5183

wants to merge 3 commits into from

Conversation

KeithPepin
Copy link

Created a demo page illustrating how a listview grid widget could work.

Still To Do: add display: inline-block version to compliment the floated

  • version.

  • Scott Jehl and others added 3 commits October 15, 2012 17:55
    TODO: Make split buttons work somehow, create a variant with large
    photos that stretch for an album example,  fix highlight on darker
    themes
    To Do: Add secon version based on display-inline: block instead of float: left;
    
    Files Impacted:
      jquery.mobile.structure.css
      lists-grid-demos.html
      listview.js
    @KeithPepin KeithPepin mentioned this pull request Oct 16, 2012
    @scottjehl
    Copy link

    Hey Keith! A couple of things.

    First, it looks like you've got 2 different commits in this pull - the first deals with listview grid while the second is a fix for the title issue. Unfortunately, we'll need these separated to pull them in (thought I had pulled that in yesterday, oddly) .
    Anyway, the main issue with this PR is that it points to our Master branch, rather than our listview-grid branch. We can pull it into that branch manually, but it's better if we close this out and resend the PR from to that branch in particular.

    Would you mind closing this out and doing that? Thanks!!

    @KeithPepin
    Copy link
    Author

    Hi Scott:

    First, thanks again for the help along the way during the Summit.  It helps to have some understanding folks that know the tools help show you the ropes.  Case in point...

    Sorry about the git mix up.  I'll take some time either this evening or later this afternoon to resubmit the request.  I haven't touched any of the files on my laptop sicne the Summit so everything should still be intact.  Hopefully I'll get it right this time.  :P

    You did pull in the change to the title already to master, so I wouldn't worry about that.  I had made the same change in the list-grid stuff just so we would have it and it wouldn't impact the demo page.  Those files were strictly intended for the list-grid branch, but apparently I had the pull setup incorrectly to go to master (defintiely did not intend that, and clearly that's not where those belong).

    Not sure how to close it out, but I'll dig a bit and make it happen.  :)

    Keith

     
    Keith M. Pepin
    26 Prestonfield Road
    Nashua, NH  03064

     


    From: Scott Jehl [email protected]
    To: jquery/jquery-mobile [email protected]
    Cc: Keith Pepin [email protected]
    Sent: Wednesday, October 17, 2012 3:59 PM
    Subject: Re: [jquery-mobile] Listview grid - created demo illustrating how it could work (#5183)

    Hey Keith! A couple of things.
    First, it looks like you've got 2 different commits in this pull - the first deals with listview grid while the second is a fix for the title issue. Unfortunately, we'll need these separated to pull them in (thought I had pulled that in yesterday, oddly) .
    Anyway, the main issue with this PR is that it points to our Master branch, rather than our listview-grid branch. We can pull it into that branch manually, but it's better if we close this out and resend the PR from to that branch in particular.
    Would you mind closing this out and doing that? Thanks!!

    Reply to this email directly or view it on GitHub.

    @scottjehl
    Copy link

    Thanks, Keith! Closed out.

    @scottjehl scottjehl closed this Oct 18, 2012
    Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants